Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: silence help when error returned for ulxly commands #499

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

jhkimqd
Copy link
Contributor

@jhkimqd jhkimqd commented Feb 12, 2025

Description

This PR silences the help message when an error is returned using the polycli ulxly commands.

With the refactoring in the bridging CI, we now attempt to claim the deposit every few seconds, and it is nearly guaranteed to fail in the first few tries and this produces a lot of unnecessary help messages. This PR cleans the logs within Kurtosis CDK CI, and shouldn't affect user experience as the usage can always be retrieved using the --help flag.

image

Signed-off-by: Ji Hwan <jkim@polygon.technology>
@jhkimqd jhkimqd enabled auto-merge February 12, 2025 03:42
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jhkimqd jhkimqd merged commit c05bb83 into main Feb 12, 2025
6 checks passed
@jhkimqd jhkimqd deleted the jihwan/silence-ulxly-help branch February 12, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants